-
-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove v2 frontend components #1156
Conversation
Some details and questions about this PR:
|
@brichet Thanks for the info! Let me answer your questions:
Sure. If
No need IMO. The existing feature is a bit ugly, and the replace/insert actions are unnecessary. We will probably want some kind of chat message menu in
Yes, deleting this is fine. Brian and I don't see the need to include this feature as part of v3 given that it will likely be superseded by some upcoming features.
Keep |
@dlqqq thanks for your answers. I removed the remaining components, it should be ready now. |
c9dca76
to
011afc8
Compare
|
||
test('shows chat welcome message', async () => { | ||
await ai.assertSnapshot(FILENAMES.CHAT_WELCOME_MESSAGE); | ||
test('Should be tested', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lmao
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it and this works well, thank you so much for helping with this! 🤗
There's probably still a few unused JS files, but we can iterate on this in future PRs.
Note that the Python 3.9 tests are failing because of the
|
Opened a new issue upstream to track this: jupyterlab/jupyter-chat#134 |
This PR aims to clean the v2 code.
Fixes #1146